JavaScript Оценка не возрастает

Я программирую маленькое имя картинной игры в HTML и JavaScript, и у меня есть небольшая проблема с увеличением значения оценки, когда пользователь получает ответ правильно, значение оценки не увеличивается, так что звезды не меняется при получении ответа correct.I предоставили мой код до сих пор, и любая помощь будет принята с благодарностьюJavaScript Оценка не возрастает

<script language="javascript"> 
var Pics; 
var Score = 0; 

function btnStart_onClick() { 
    document.getElementById("btnBS").disabled = false; 
    document.getElementById("btnBW").disabled = false; 
    document.getElementById("btnCP").disabled = false; 
    document.getElementById("btnFP").disabled = false; 
    document.getElementById("btnPH").disabled = false; 
    document.getElementById("btnPW").disabled = false; 
    document.getElementById("btnRD").disabled = false; 
    document.getElementById("btnTP").disabled = false; 
    document.getElementById("btnTS").disabled = false; 
    document.getElementById("btnYH").disabled = false; 
    document.getElementById("btnStart").disabled = true; 
    document.getElementById("Ptxt").innerHTML = "What is the above symbol?" 
    Pics = Math.floor(Math.random() * 10) + 1 

    if (Pics == 0) 
     "MapSym_blank.jpg" 
    else if (Pics == 1) 
     Picture.src = "MapSym_BS.jpg" 
    else if (Pics == 2) 
     Picture.src = "MapSym_BW.jpg" 
    else if (Pics == 3) 
     Picture.src = "MapSym_CP.jpg" 
    else if (Pics == 4) 
     Picture.src = "MapSym_FP.jpg" 
    else if (Pics == 5) 
     Picture.src = "MapSym_PH.jpg" 
    else if (Pics == 6) 
     Picture.src = "MapSym_PW.jpg" 
    else if (Pics == 7) 
     Picture.src = "MapSym_RD.jpg" 
    else if (Pics == 8) 
     Picture.src = "MapSym_TP.jpg" 
    else if (Pics == 9) 
     Picture.src = "MapSym_TS.jpg" 
    else if (Pics == 10) 
     Picture.src = "MapSym_YH.jpg" 
} 
function btnBS_onClick() { 
    document.getElementById("btnBS").disabled = true; 
    document.getElementById("btnBW").disabled = true; 
    document.getElementById("btnCP").disabled = true; 
    document.getElementById("btnFP").disabled = true; 
    document.getElementById("btnPH").disabled = true; 
    document.getElementById("btnPW").disabled = true; 
    document.getElementById("btnRD").disabled = true; 
    document.getElementById("btnTP").disabled = true; 
    document.getElementById("btnTS").disabled = true; 
    document.getElementById("btnYH").disabled = true; 
    document.getElementById("btnStart").disabled = false; 

    if (Pics == 1) { 
     document.getElementById("Ptxt").innerHTML = "Congratulations" 
     Score += 1 
    } 
    else document.getElementById("Ptxt").innerHTML = "Try Again" 
} 
    function btnBW_onClick() { 
     document.getElementById("btnBS").disabled = true; 
     document.getElementById("btnBW").disabled = true; 
     document.getElementById("btnCP").disabled = true; 
     document.getElementById("btnFP").disabled = true; 
     document.getElementById("btnPH").disabled = true; 
     document.getElementById("btnPW").disabled = true; 
     document.getElementById("btnRD").disabled = true; 
     document.getElementById("btnTP").disabled = true; 
     document.getElementById("btnTS").disabled = true; 
     document.getElementById("btnYH").disabled = true; 
     document.getElementById("btnStart").disabled = false; 

     if (Pics == 2) { 
      document.getElementById("Ptxt").innerHTML = "Congratulations" 
      Score += 1 
     } 
     else document.getElementById("Ptxt").innerHTML = "Try Again" 
    } 
    function btnCP_onClick() { 
     document.getElementById("btnBS").disabled = true; 
     document.getElementById("btnBW").disabled = true; 
     document.getElementById("btnCP").disabled = true; 
     document.getElementById("btnFP").disabled = true; 
     document.getElementById("btnPH").disabled = true; 
     document.getElementById("btnPW").disabled = true; 
     document.getElementById("btnRD").disabled = true; 
     document.getElementById("btnTP").disabled = true; 
     document.getElementById("btnTS").disabled = true; 
     document.getElementById("btnYH").disabled = true; 
     document.getElementById("btnStart").disabled = false; 

     if (Pics == 3) { 
      document.getElementById("Ptxt").innerHTML = "Congratulations" 
      Score += 1 
     } 
     else document.getElementById("Ptxt").innerHTML = "Try Again" 
    } 
    function btnFP_onClick() { 
     document.getElementById("btnBS").disabled = true; 
     document.getElementById("btnBW").disabled = true; 
     document.getElementById("btnCP").disabled = true; 
     document.getElementById("btnFP").disabled = true; 
     document.getElementById("btnPH").disabled = true; 
     document.getElementById("btnPW").disabled = true; 
     document.getElementById("btnRD").disabled = true; 
     document.getElementById("btnTP").disabled = true; 
     document.getElementById("btnTS").disabled = true; 
     document.getElementById("btnYH").disabled = true; 
     document.getElementById("btnStart").disabled = false; 

     if (Pics == 4) { 
      document.getElementById("Ptxt").innerHTML = "Congratulations" 
      Score += 1 
     } 
     else document.getElementById("Ptxt").innerHTML = "Try Again" 
    } 
    function btnPH_onClick() { 
     document.getElementById("btnBS").disabled = true; 
     document.getElementById("btnBW").disabled = true; 
     document.getElementById("btnCP").disabled = true; 
     document.getElementById("btnFP").disabled = true; 
     document.getElementById("btnPH").disabled = true; 
     document.getElementById("btnPW").disabled = true; 
     document.getElementById("btnRD").disabled = true; 
     document.getElementById("btnTP").disabled = true; 
     document.getElementById("btnTS").disabled = true; 
     document.getElementById("btnYH").disabled = true; 
     document.getElementById("btnStart").disabled = false; 

     if (Pics == 5) { 
      document.getElementById("Ptxt").innerHTML = "Congratulations" 
      Score += 1 
     } 
     else document.getElementById("Ptxt").innerHTML = "Try Again" 
    } 
    function btnPW_onClick() { 
     document.getElementById("btnBS").disabled = true; 
     document.getElementById("btnBW").disabled = true; 
     document.getElementById("btnCP").disabled = true; 
     document.getElementById("btnFP").disabled = true; 
     document.getElementById("btnPH").disabled = true; 
     document.getElementById("btnPW").disabled = true; 
     document.getElementById("btnRD").disabled = true; 
     document.getElementById("btnTP").disabled = true; 
     document.getElementById("btnTS").disabled = true; 
     document.getElementById("btnYH").disabled = true; 
     document.getElementById("btnStart").disabled = false; 

     if (Pics == 6) { 
      document.getElementById("Ptxt").innerHTML = "Congratulations" 
      Score += 1 
     } 
     else document.getElementById("Ptxt").innerHTML = "Try Again" 
    } 
    function btnRD_onClick() { 
     document.getElementById("btnBS").disabled = true; 
     document.getElementById("btnBW").disabled = true; 
     document.getElementById("btnCP").disabled = true; 
     document.getElementById("btnFP").disabled = true; 
     document.getElementById("btnPH").disabled = true; 
     document.getElementById("btnPW").disabled = true; 
     document.getElementById("btnRD").disabled = true; 
     document.getElementById("btnTP").disabled = true; 
     document.getElementById("btnTS").disabled = true; 
     document.getElementById("btnYH").disabled = true; 
     document.getElementById("btnStart").disabled = false; 

     if (Pics == 7) { 
      document.getElementById("Ptxt").innerHTML = "Congratulations" 
      Score += 1 
     } 
     else document.getElementById("Ptxt").innerHTML = "Try Again" 
    } 
    function btnTP_onClick() { 
     document.getElementById("btnBS").disabled = true; 
     document.getElementById("btnBW").disabled = true; 
     document.getElementById("btnCP").disabled = true; 
     document.getElementById("btnFP").disabled = true; 
     document.getElementById("btnPH").disabled = true; 
     document.getElementById("btnPW").disabled = true; 
     document.getElementById("btnRD").disabled = true; 
     document.getElementById("btnTP").disabled = true; 
     document.getElementById("btnTS").disabled = true; 
     document.getElementById("btnYH").disabled = true; 
     document.getElementById("btnStart").disabled = false; 

     if (Pics == 8) { 
      document.getElementById("Ptxt").innerHTML = "Congratulations" 
      Score += 1 
     } 
     else document.getElementById("Ptxt").innerHTML = "Try Again" 
    } 
    function btnTS_onClick() { 
     document.getElementById("btnBS").disabled = true; 
     document.getElementById("btnBW").disabled = true; 
     document.getElementById("btnCP").disabled = true; 
     document.getElementById("btnFP").disabled = true; 
     document.getElementById("btnPH").disabled = true; 
     document.getElementById("btnPW").disabled = true; 
     document.getElementById("btnRD").disabled = true; 
     document.getElementById("btnTP").disabled = true; 
     document.getElementById("btnTS").disabled = true; 
     document.getElementById("btnYH").disabled = true; 
     document.getElementById("btnStart").disabled = false; 

     if (Pics == 9) { 
      document.getElementById("Ptxt").innerHTML = "Congratulations" 
      Score += 1 
     } 
     else document.getElementById("Ptxt").innerHTML = "Try Again" 
    } 
    function btnYH_onClick() { 
     document.getElementById("btnBS").disabled = true; 
     document.getElementById("btnBW").disabled = true; 
     document.getElementById("btnCP").disabled = true; 
     document.getElementById("btnFP").disabled = true; 
     document.getElementById("btnPH").disabled = true; 
     document.getElementById("btnPW").disabled = true; 
     document.getElementById("btnRD").disabled = true; 
     document.getElementById("btnTP").disabled = true; 
     document.getElementById("btnTS").disabled = true; 
     document.getElementById("btnYH").disabled = true; 
     document.getElementById("btnStart").disabled = false; 

     if (Pics == 10) { 
      document.getElementById("Ptxt").innerHTML = "Congratulations" 
      Score += 1 
     } 
     else document.getElementById("Ptxt").innerHTML = "Try Again" 
    } 

    if (Score == 1) { 
     SOff1.src = "StarOn.gif" 
    } 
    if (Score == 2) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
    } 
    if (Score == 3) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
     Soff3.src = "StarOn.gif" 
    } 
    if (Score == 4) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
     Soff3.src = "StarOn.gif" 
     Soff4.src = "StarOn.gif" 
    } 
    if (Score == 5) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
     Soff3.src = "StarOn.gif" 
     Soff4.src = "StarOn.gif" 
     Soff5.src = "StarOn.gif" 
    } 
</script>

источник

2016-12-07 Ben Arnold

Добро пожаловать в StackOverflow. Вы должны сообщить нам, какую конкретную проблему вы испытываете. Вы получили сообщение об ошибке? Вы получаете неправильный вывод? – curt

извините, я обновляю сообщение, но оценка просто не увеличивается при нажатии правильной кнопки –

Вы можете уменьшить этот код до 1/10 его. Слишком много повторений. – trincot

Вы должны поместить это:

if (Score == 1) { 
     SOff1.src = "StarOn.gif" 
    } 
    if (Score == 2) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
    } 
    if (Score == 3) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
     Soff3.src = "StarOn.gif" 
    } 
    if (Score == 4) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
     Soff3.src = "StarOn.gif" 
     Soff4.src = "StarOn.gif" 
    } 
    if (Score == 5) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
     Soff3.src = "StarOn.gif" 
     Soff4.src = "StarOn.gif" 
     Soff5.src = "StarOn.gif" 
    }

в свою собственную функцию и называть ее в нижней части всех ваших событий click

Ex:

function btnYH_onClick() { 
    document.getElementById("btnBS").disabled = true; 
    document.getElementById("btnBW").disabled = true; 
    document.getElementById("btnCP").disabled = true; 
    document.getElementById("btnFP").disabled = true; 
    document.getElementById("btnPH").disabled = true; 
    document.getElementById("btnPW").disabled = true; 
    document.getElementById("btnRD").disabled = true; 
    document.getElementById("btnTP").disabled = true; 
    document.getElementById("btnTS").disabled = true; 
    document.getElementById("btnYH").disabled = true; 
    document.getElementById("btnStart").disabled = false; 

    if (Pics == 10) { 
     document.getElementById("Ptxt").innerHTML = "Congratulations" 
     Score += 1 
    } 
    else document.getElementById("Ptxt").innerHTML = "Try Again" 

    setScore(); 
} 


function setScore() { 
     if (Score == 1) { 
     SOff1.src = "StarOn.gif" 
    } 
    if (Score == 2) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
    } 
    if (Score == 3) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
     Soff3.src = "StarOn.gif" 
    } 
    if (Score == 4) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
     Soff3.src = "StarOn.gif" 
     Soff4.src = "StarOn.gif" 
    } 
    if (Score == 5) { 
     SOff1.src = "StarOn.gif" 
     SOff2.src = "StarOn.gif" 
     Soff3.src = "StarOn.gif" 
     Soff4.src = "StarOn.gif" 
     Soff5.src = "StarOn.gif" 
    } 
}

источник

2016-12-07 20:04:57

отлично, это именно то, что мне нужно, и отлично работает спасибо! –

JavaScript Оценка не возрастает

ответ

Смежные вопросы