asp.net не может обновить базу данных

Question

string ConnectionString = WebConfigurationManager.ConnectionStrings["dbnameConnectionString"].ConnectionString; 
SqlConnection myConnection = new SqlConnection(ConnectionString); 

myConnection.Open(); 
try 
{ 
    string qry = "UPDATE customers SET firstname=@firstname WHERE cid=1"; 
    SqlCommand insertQuery = new SqlCommand(qry, myConnection); 
    insertQuery.Parameters.Add(new SqlParameter("@firstname", txtFirstname.Text)); 
    insertQuery.ExecuteNonQuery(); 

    myConnection.Close(); 
} 
catch (Exception ee) 
{ 

} 

Любые предложения?

Answer 1

Немного очистки вашего кода вы можете попробовать (вы должны распоряжаться IDisposable объектов):

string ConnectionString = // ... 
using (var connection = new SqlConnection(ConnectionString)) 
using (var command = connection.CreateCommand()) 
{ 
    connection.Open(); 
    command.CommandText = "UPDATE customers SET firstname = @firstname WHERE cid=1"; 
    command.Parameters.AddWithValue("@firstname", txtFirstname.Text); 
    var rowsUpdated = command.ExecuteNonQuery(); 
}